[GitHub] asfgit closed pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] asfgit closed pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

GitBox
asfgit closed pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things
URL: https://github.com/apache/geronimo-jwt-auth/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.adoc b/README.adoc
index a2839fc..0775005 100644
--- a/README.adoc
+++ b/README.adoc
@@ -17,8 +17,6 @@ IMPORTANT: you can also use the eclipse bundle.
 
 === Implementation
 
-IMPORTANT: you can also use the eclipse bundle.
-
 [source,xml]
 ----
 <parent>
@@ -77,10 +75,10 @@ geronimo.jwt-auth.kids.key.mapping = \
 kid1 = /publicKey.pem
 ----
 
-== OpenWebBeans
+== Apache OpenWebBeans
 
-For this specification to work on OpenWebBeans you need to configure a few key (until 2.0.4).
-For that register a `META-INF/openwebbeans/openwebbeans.properties`:
+For this specification to work on Apache OpenWebBeans you need to configure a few keys (until 2.0.4).
+For that, register a `META-INF/openwebbeans/openwebbeans.properties`:
 
 [source,properties]
 ----
@@ -108,4 +106,4 @@ public class MySecurityService extends SimpleSecurityService {
 }
 ----
 
-IMPORTANT: in any case it is not recommanded to use CDI `Principal` API, always prefer `JsonWebToken` one.
+IMPORTANT: in any case it is not recommended to use CDI `Principal` API, always prefer `JsonWebToken` one.
diff --git a/geronimo-jwt-auth-impl/pom.xml b/geronimo-jwt-auth-impl/pom.xml
index bd18d80..44daa2f 100644
--- a/geronimo-jwt-auth-impl/pom.xml
+++ b/geronimo-jwt-auth-impl/pom.xml
@@ -27,8 +27,6 @@
   <name>Geronimo JWT Auth :: Impl</name>
 
   <properties>
-    <tck.version>1.1-SNAPSHOT</tck.version>
-
     <geronimo.jpms.name>org.apache.geronimo.microprofile.jwtauth</geronimo.jpms.name>
   </properties>
 
diff --git a/geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java b/geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java
index d24c249..aed9b2d 100644
--- a/geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java
+++ b/geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java
@@ -395,9 +395,6 @@ public Claims standard() {
             return claims;
         }
 
-        @Override
-        public String toString() {
-            return super.toString().replace(", ", ", ");
-        }
+    }
     }
 }
diff --git a/geronimo-microprofile-jwt-auth-spec/pom.xml b/geronimo-microprofile-jwt-auth-spec/pom.xml
index a8b2362..7c9cdee 100644
--- a/geronimo-microprofile-jwt-auth-spec/pom.xml
+++ b/geronimo-microprofile-jwt-auth-spec/pom.xml
@@ -25,7 +25,7 @@
   <modelVersion>4.0.0</modelVersion>
 
   <artifactId>geronimo-microprofile-jwt-auth-spec</artifactId>
-  <name>Geronimo JWT Auth :: Spec 1.1</name>
+  <name>Geronimo JWT Auth :: Spec ${tck.version}</name>
 
   <properties>
     <!-- undefined? -->
diff --git a/geronimo-microprofile-jwt-auth-spec/src/main/java/org/eclipse/microprofile/jwt/ClaimValue.java b/geronimo-microprofile-jwt-auth-spec/src/main/java/org/eclipse/microprofile/jwt/ClaimValue.java
index b2cb88d..a91da9d 100644
--- a/geronimo-microprofile-jwt-auth-spec/src/main/java/org/eclipse/microprofile/jwt/ClaimValue.java
+++ b/geronimo-microprofile-jwt-auth-spec/src/main/java/org/eclipse/microprofile/jwt/ClaimValue.java
@@ -25,7 +25,20 @@
  * @param <TYPE> the expected type of the value.
  */
 public interface ClaimValue<TYPE> extends Principal {
+
+    /**
+     * This is the name of the claim we need an injection for.
+     * Check out org.eclipse.microprofile.jwt.Claims for a list of well known claims.
+     *
+     * @return name of the claim
+     */
     @Override
     String getName();
+
+    /**
+     * The value of the claim extracted from the JWT for the key defined above.
+     *
+     * @return the value of the claim
+     */
     TYPE getValue();
 }
diff --git a/pom.xml b/pom.xml
index c4cab46..22790f6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -46,6 +46,10 @@
     <module>geronimo-jwt-auth-impl</module>
   </modules>
 
+  <properties>
+    <tck.version>1.1</tck.version>
+  </properties>
+
   <dependencies>
     <dependency>
       <groupId>org.apache.tomcat</groupId>
@@ -123,7 +127,7 @@
     <url>http://www.apache.org/</url>
   </organization>
 
-  <inceptionYear>2017</inceptionYear>
+  <inceptionYear>2018</inceptionYear>
 
   <licenses>
     <license>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services