[GitHub] geronimo-specs pull request #8: [GERONIMO-6601] adds Automatic-Module-Name

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] geronimo-specs pull request #8: [GERONIMO-6601] adds Automatic-Module-Name

rotty3000
GitHub user christopher-johnson opened a pull request:

    https://github.com/apache/geronimo-specs/pull/8

    [GERONIMO-6601] adds Automatic-Module-Name

    the duplication of the maven-jar-plugin configuration in every module pom.xml seems required with the current project hierarchy.  
   
    The value of  
    ```xml
    <Automatic-Module-Name>
    ```
    is set in a property `<automatic.module.name>` in the event that this should change.
   
    The property values are consistent with the top-level exported package name with a few exceptions.  Several specs export more than one primary package, for example, `geronimo-jcdi_1.0_spec`, that exports
    `javax.decorator` and  `javax.enterprise`.  In that case, I arbitrarily chose `javax.decorator`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/christopher-johnson/geronimo-specs automatic-modules

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geronimo-specs/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
   
----
commit 9258a9fb73ffce045ee104523d58c4ddf7b83599
Author: Christopher Hanna Johnson <chjohnson39@...>
Date:   2018-03-18T16:44:05Z

    [GERONIMO-6601] adds Automatic-Module-Name

----


---