[GitHub] geronimo-specs pull request #9: GERONIMO-6606 Apply Portable Java Contracts ...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] geronimo-specs pull request #9: GERONIMO-6606 Apply Portable Java Contracts ...

rotty3000
GitHub user rotty3000 opened a pull request:

    https://github.com/apache/geronimo-specs/pull/9

    GERONIMO-6606 Apply Portable Java Contracts to all specs

    Signed-off-by: Raymond Auge <[hidden email]>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rotty3000/geronimo-specs GERONIMO-6606

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geronimo-specs/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
   
----
commit f45f9919d348244652cd6598837c50a4bd9b88a9
Author: Raymond Auge <rotty3000@...>
Date:   2018-05-15T19:35:18Z

    GERONIMO-6606 Apply Portable Java Contracts to all specs
   
    Signed-off-by: Raymond Auge <[hidden email]>

----


---
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] geronimo-specs pull request #9: GERONIMO-6606 Apply Portable Java Contracts ...

Mark Struberg
That looks like a very solid PR,
gonna give it a more detailed review today or tomorrow, but looks really good!

Thanks Raymond!

txs and LieGrue,
strub


> Am 15.05.2018 um 21:38 schrieb rotty3000 <[hidden email]>:
>
> GitHub user rotty3000 opened a pull request:
>
>    https://github.com/apache/geronimo-specs/pull/9
>
>    GERONIMO-6606 Apply Portable Java Contracts to all specs
>
>    Signed-off-by: Raymond Auge <[hidden email]>
>
> You can merge this pull request into a Git repository by running:
>
>    $ git pull https://github.com/rotty3000/geronimo-specs GERONIMO-6606
>
> Alternatively you can review and apply these changes as the patch at:
>
>    https://github.com/apache/geronimo-specs/pull/9.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>    This closes #9
>
> ----
> commit f45f9919d348244652cd6598837c50a4bd9b88a9
> Author: Raymond Auge <rotty3000@...>
> Date:   2018-05-15T19:35:18Z
>
>    GERONIMO-6606 Apply Portable Java Contracts to all specs
>
>    Signed-off-by: Raymond Auge <[hidden email]>
>
> ----
>
>
> ---

Reply | Threaded
Open this post in threaded view
|

[GitHub] geronimo-specs pull request #9: GERONIMO-6606 Apply Portable Java Contracts ...

rotty3000
In reply to this post by rotty3000
Github user cthistle closed the pull request at:

    https://github.com/apache/geronimo-specs/pull/9


---