[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442816821
 
 
   I actually now get it, but adding map there doesn't work:
   
   return ofNullable(metricRegistry.getMetrics().get(name))
                   .map(metric -> singletonMap(name, map(metric)))
                   .orElseGet(Collections::emptyMap);
   
   It will change the return type from Metric to Object and won't work for other methods that are using it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services