[GitHub] rmannibucau commented on a change in pull request #1: jdk9+ compilation

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rmannibucau commented on a change in pull request #1: jdk9+ compilation

GitBox
rmannibucau commented on a change in pull request #1: jdk9+ compilation
URL: https://github.com/apache/geronimo-openapi/pull/1#discussion_r205850019
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -169,6 +170,13 @@
         <optional>true</optional>
       </dependency>
 
+      <dependency>
+        <groupId>javax.activation</groupId>
+        <artifactId>javax.activation-api</artifactId>
+        <version>${javax.activation.version}</version>
 
 Review comment:
   We must not deliver it for java 8, why not using scope provided? Also from what i saw it is a cxf issue more than the openapi one, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services