[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things
URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355
 
 

 ##########
 File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml
 ##########
 @@ -40,8 +40,6 @@
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.ProviderInjectionTest" />
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.RolesAllowedTest" />
       <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.InvalidTokenTest" />
-      <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.PrimitiveInjectionTest" />
 
 Review comment:
   Tck regression?
   
   edit: no need to remove them, it passes so only the tostring+version upgrade IMHO

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services