[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442598808
 
 
   If you look the code of singleEntry (what you changed) you will see it just misses a map on the metric otherwise it is exactly the same so idea was to fix singleEntry instead of duplicating the code
   
   Side note: please dont add a test module and write the test in common module - not even need a server or endpoint ;).
   
   If still unclear and you are ok i am also fine to just do it tomorrow, it shouldnt be more than 15mn so sure i can do it for you too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services