[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json
URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442826327
 
 
   > It will change the return type from Metric to Object and won't work for other methods that are using it.
   
   I'm pretty confident we can make it work, worse case we add a toggle in map method but all endpoints should return the same representation
   
   > When you say a server or an endpoint are not necessary, how would you do it?
   
   a plain new of the endpoint then you have setters and can call endpoint to check the returned model, no need to go through serialization here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services