Patch for EJBMethodPermissions - EJB with all methods unchecked

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for EJBMethodPermissions - EJB with all methods unchecked

Ivan S. Dubrov-2
Hello,

Attached is the patch fixing very nasty error regarding the EJBMethodPermissions. Without this patch MethodSpec with parameters methodName=null, methodInterface=null, methodParam=null deserializes with params methodName=null, methodInterface=null, methodParam="" (note the methodParams)! As a result, EJB beans with all methods <unchecked/> do not work - AccessControlException is thrown (since methodParam="" means no-arg methods, whille methodParam=null means any methods).

Ivan Dubrov.

patch (702 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for EJBMethodPermissions - EJB with all methods unchecked

David Jencks
I think you are correct, but I'm nervous about applying this without a
unit test.  Could you open a JIRA issue and include the xml method
permission that causes the problem?  If you want to write a unit test
that would be even better :-)

thanks
david jencks

On Jun 2, 2005, at 5:53 AM, Ivan S. Dubrov wrote:

> Hello,
>
> Attached is the patch fixing very nasty error regarding the
> EJBMethodPermissions. Without this patch MethodSpec with parameters
> methodName=null, methodInterface=null, methodParam=null deserializes
> with params methodName=null, methodInterface=null, methodParam=""
> (note the methodParams)! As a result, EJB beans with all methods
> <unchecked/> do not work - AccessControlException is thrown (since
> methodParam="" means no-arg methods, whille methodParam=null means any
> methods).
>
> Ivan Dubrov.
> <patch>

Reply | Threaded
Open this post in threaded view
|

Re: Patch for EJBMethodPermissions - EJB with all methods unchecked

Dain Sundstrom
Ivan,

I really appreciate the patch.  I think this may fix one of the  
failures I've been seeing lately.  Please file a bug report, I'll  
assign it to Jeff, and hopefully can test this one out quickly.

Thank,

-dain

On Jun 2, 2005, at 10:33 AM, David Jencks wrote:

> I think you are correct, but I'm nervous about applying this  
> without a unit test.  Could you open a JIRA issue and include the  
> xml method permission that causes the problem?  If you want to  
> write a unit test that would be even better :-)
>
> thanks
> david jencks
>
> On Jun 2, 2005, at 5:53 AM, Ivan S. Dubrov wrote:
>
>
>> Hello,
>>
>> Attached is the patch fixing very nasty error regarding the  
>> EJBMethodPermissions. Without this patch MethodSpec with  
>> parameters methodName=null, methodInterface=null, methodParam=null  
>> deserializes with params methodName=null, methodInterface=null,  
>> methodParam="" (note the methodParams)! As a result, EJB beans  
>> with all methods <unchecked/> do not work - AccessControlException  
>> is thrown (since methodParam="" means no-arg methods, whille  
>> methodParam=null means any methods).
>>
>> Ivan Dubrov.
>> <patch>
>