[VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Mark Struberg
Hi folks!

I fixed a few missing parts and did run the release steps for geronimo-config-1.2
This implements the microprofile-config-1.3 spec.

The staging repository is here:
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/

The source zip is under
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
sha1 is 7de2e31a5022379f093d1f186aab97d731fe24a5

Please VOTE:

[+1] yea, let's ship it!
[+0] meh, don't care
[-1] stop because ${showstopper}

The VOTE is open for 72h

txs and LieGrue,
strub

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Romain Manni-Bucau
+1, also migrated a few apps from deltaspike and once the API missing features worked around it seems working well.

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le ven. 8 juin 2018 à 13:55, Mark Struberg <[hidden email]> a écrit :
Hi folks!

I fixed a few missing parts and did run the release steps for geronimo-config-1.2
This implements the microprofile-config-1.3 spec.

The staging repository is here:
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/

The source zip is under
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
sha1
is 7de2e31a5022379f093d1f186aab97d731fe24a5

Please VOTE:

[+1] yea, let's ship it!
[+0] meh, don't care
[-1] stop because ${showstopper}

The VOTE is open for 72h

txs and LieGrue,
strub

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Rudy De Busscher
+0

Maybe some minor 'beauty issues' but 

1. There are quite some methods (and even a class) which are not needed (not used and without them, TCK will still run successfull)

cdi.ConfigBean -> should be removed (not used)

ConfigImpl#onAttributeChange -> should be removed (not used)

ConfigValueImpl#asSet -> should be removed (not used)
ConfigValueImpl#getDefaultValue -> should be removed (not used)
ConfigValueImpl#useConverter -> should be removed (not used)
ConfigValueImpl#cacheFor -> should be removed (not used)
ConfigValueImpl#withLookupChain -> should be removed (not used)
ConfigValueImpl#getOptionalValue -> should be removed (not used)
ConfigValueImpl#getValueList -> should be removed (not used)
ConfigValueImpl#getPropertyName -> should be removed (not used)
ConfigValueImpl#getResolvedPropertyName -> should be removed (not used)

2. ConfigValueImpl has only @Typed, other have @Typed and @Vetoed. Should be consistent.

3. Unused import at 

ConfigExtension.java

ConfigInjectionBean.java

ConfigValueImpl.java

DefaultConfigBuilder.java


4. Java 8 usage improvements
4a. explicit type can be replaced with <> at

DefaultConfigProvider:41

PropertyFileConfigSourceProvider:47


4b. Use try-with-resource within 

PropertyFileConfigSource#loadProperties









On Fri, 8 Jun 2018 at 14:02, Romain Manni-Bucau <[hidden email]> wrote:
+1, also migrated a few apps from deltaspike and once the API missing features worked around it seems working well.

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le ven. 8 juin 2018 à 13:55, Mark Struberg <[hidden email]> a écrit :
Hi folks!

I fixed a few missing parts and did run the release steps for geronimo-config-1.2
This implements the microprofile-config-1.3 spec.

The staging repository is here:
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/

The source zip is under
https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
sha1
is 7de2e31a5022379f093d1f186aab97d731fe24a5

Please VOTE:

[+1] yea, let's ship it!
[+0] meh, don't care
[-1] stop because ${showstopper}

The VOTE is open for 72h

txs and LieGrue,
strub

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Mark Struberg
Most of the functionallity which is unused right now will be used in the next version.
It's just that the features are not yet backported from ConfigJSR to mp-config.
This is planned for 1.4. So I'll not remove those methods because they will soon make sense.
And a user can already upcast and use them.

Pleae go ahead and ship a patch for the try-with-resources. Would be really appreciated!

txs and LieGrue,
strub

> Am 09.06.2018 um 21:05 schrieb Rudy De Busscher <[hidden email]>:
>
> +0
>
> Maybe some minor 'beauty issues' but
>
> 1. There are quite some methods (and even a class) which are not needed (not used and without them, TCK will still run successfull)
>
> cdi.ConfigBean -> should be removed (not used)
>
> ConfigImpl#onAttributeChange -> should be removed (not used)
>
> ConfigValueImpl#asSet -> should be removed (not used)
> ConfigValueImpl#getDefaultValue -> should be removed (not used)
> ConfigValueImpl#useConverter -> should be removed (not used)
> ConfigValueImpl#cacheFor -> should be removed (not used)
> ConfigValueImpl#withLookupChain -> should be removed (not used)
> ConfigValueImpl#getOptionalValue -> should be removed (not used)
> ConfigValueImpl#getValueList -> should be removed (not used)
> ConfigValueImpl#getPropertyName -> should be removed (not used)
> ConfigValueImpl#getResolvedPropertyName -> should be removed (not used)
>
> 2. ConfigValueImpl has only @Typed, other have @Typed and @Vetoed. Should be consistent.
>
> 3. Unused import at
> ConfigExtension.java
> ConfigInjectionBean.java
> ConfigValueImpl.java
> DefaultConfigBuilder.java
>
> 4. Java 8 usage improvements
> 4a. explicit type can be replaced with <> at
> DefaultConfigProvider:41
> PropertyFileConfigSourceProvider:47
>
> 4b. Use try-with-resource within
> PropertyFileConfigSource#loadProperties
>
>
>
>
>
>
>
>
> On Fri, 8 Jun 2018 at 14:02, Romain Manni-Bucau <[hidden email]> wrote:
> +1, also migrated a few apps from deltaspike and once the API missing features worked around it seems working well.
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le ven. 8 juin 2018 à 13:55, Mark Struberg <[hidden email]> a écrit :
> Hi folks!
>
> I fixed a few missing parts and did run the release steps for geronimo-config-1.2
> This implements the microprofile-config-1.3 spec.
>
> The staging repository is here:
> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/
>
> The source zip is under
> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
> sha1 is 7de2e31a5022379f093d1f186aab97d731fe24a5
>
> Please VOTE:
>
> [+1] yea, let's ship it!
> [+0] meh, don't care
> [-1] stop because ${showstopper}
>
> The VOTE is open for 72h
>
> txs and LieGrue,
> strub
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Mark Struberg
btw, here is my +1

LieGrue,
strub


> Am 10.06.2018 um 14:34 schrieb Mark Struberg <[hidden email]>:
>
> Most of the functionallity which is unused right now will be used in the next version.
> It's just that the features are not yet backported from ConfigJSR to mp-config.
> This is planned for 1.4. So I'll not remove those methods because they will soon make sense.
> And a user can already upcast and use them.
>
> Pleae go ahead and ship a patch for the try-with-resources. Would be really appreciated!
>
> txs and LieGrue,
> strub
>
>> Am 09.06.2018 um 21:05 schrieb Rudy De Busscher <[hidden email]>:
>>
>> +0
>>
>> Maybe some minor 'beauty issues' but
>>
>> 1. There are quite some methods (and even a class) which are not needed (not used and without them, TCK will still run successfull)
>>
>> cdi.ConfigBean -> should be removed (not used)
>>
>> ConfigImpl#onAttributeChange -> should be removed (not used)
>>
>> ConfigValueImpl#asSet -> should be removed (not used)
>> ConfigValueImpl#getDefaultValue -> should be removed (not used)
>> ConfigValueImpl#useConverter -> should be removed (not used)
>> ConfigValueImpl#cacheFor -> should be removed (not used)
>> ConfigValueImpl#withLookupChain -> should be removed (not used)
>> ConfigValueImpl#getOptionalValue -> should be removed (not used)
>> ConfigValueImpl#getValueList -> should be removed (not used)
>> ConfigValueImpl#getPropertyName -> should be removed (not used)
>> ConfigValueImpl#getResolvedPropertyName -> should be removed (not used)
>>
>> 2. ConfigValueImpl has only @Typed, other have @Typed and @Vetoed. Should be consistent.
>>
>> 3. Unused import at
>> ConfigExtension.java
>> ConfigInjectionBean.java
>> ConfigValueImpl.java
>> DefaultConfigBuilder.java
>>
>> 4. Java 8 usage improvements
>> 4a. explicit type can be replaced with <> at
>> DefaultConfigProvider:41
>> PropertyFileConfigSourceProvider:47
>>
>> 4b. Use try-with-resource within
>> PropertyFileConfigSource#loadProperties
>>
>>
>>
>>
>>
>>
>>
>>
>> On Fri, 8 Jun 2018 at 14:02, Romain Manni-Bucau <[hidden email]> wrote:
>> +1, also migrated a few apps from deltaspike and once the API missing features worked around it seems working well.
>>
>> Romain Manni-Bucau
>> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>>
>>
>> Le ven. 8 juin 2018 à 13:55, Mark Struberg <[hidden email]> a écrit :
>> Hi folks!
>>
>> I fixed a few missing parts and did run the release steps for geronimo-config-1.2
>> This implements the microprofile-config-1.3 spec.
>>
>> The staging repository is here:
>> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/
>>
>> The source zip is under
>> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
>> sha1 is 7de2e31a5022379f093d1f186aab97d731fe24a5
>>
>> Please VOTE:
>>
>> [+1] yea, let's ship it!
>> [+0] meh, don't care
>> [-1] stop because ${showstopper}
>>
>> The VOTE is open for 72h
>>
>> txs and LieGrue,
>> strub
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Mark Struberg
yikes, changing to -1 because there seems to have been a glitch in various different Java8 versions.

The current version is not picking up my property from my test class path after updating to the latest Oracle JDK.
getResources for "/META-INF/bla.properties" doesn't find anything
getResources for "META-INF/bla.properties" finds it just fine.

That used to work in older OracleJVM versions.
Should we do both lookups?
Or just without the leading slash?

LieGrue,
strub

> Am 10.06.2018 um 14:41 schrieb Mark Struberg <[hidden email]>:
>
> btw, here is my +1
>
> LieGrue,
> strub
>
>
>> Am 10.06.2018 um 14:34 schrieb Mark Struberg <[hidden email]>:
>>
>> Most of the functionallity which is unused right now will be used in the next version.
>> It's just that the features are not yet backported from ConfigJSR to mp-config.
>> This is planned for 1.4. So I'll not remove those methods because they will soon make sense.
>> And a user can already upcast and use them.
>>
>> Pleae go ahead and ship a patch for the try-with-resources. Would be really appreciated!
>>
>> txs and LieGrue,
>> strub
>>
>>> Am 09.06.2018 um 21:05 schrieb Rudy De Busscher <[hidden email]>:
>>>
>>> +0
>>>
>>> Maybe some minor 'beauty issues' but
>>>
>>> 1. There are quite some methods (and even a class) which are not needed (not used and without them, TCK will still run successfull)
>>>
>>> cdi.ConfigBean -> should be removed (not used)
>>>
>>> ConfigImpl#onAttributeChange -> should be removed (not used)
>>>
>>> ConfigValueImpl#asSet -> should be removed (not used)
>>> ConfigValueImpl#getDefaultValue -> should be removed (not used)
>>> ConfigValueImpl#useConverter -> should be removed (not used)
>>> ConfigValueImpl#cacheFor -> should be removed (not used)
>>> ConfigValueImpl#withLookupChain -> should be removed (not used)
>>> ConfigValueImpl#getOptionalValue -> should be removed (not used)
>>> ConfigValueImpl#getValueList -> should be removed (not used)
>>> ConfigValueImpl#getPropertyName -> should be removed (not used)
>>> ConfigValueImpl#getResolvedPropertyName -> should be removed (not used)
>>>
>>> 2. ConfigValueImpl has only @Typed, other have @Typed and @Vetoed. Should be consistent.
>>>
>>> 3. Unused import at
>>> ConfigExtension.java
>>> ConfigInjectionBean.java
>>> ConfigValueImpl.java
>>> DefaultConfigBuilder.java
>>>
>>> 4. Java 8 usage improvements
>>> 4a. explicit type can be replaced with <> at
>>> DefaultConfigProvider:41
>>> PropertyFileConfigSourceProvider:47
>>>
>>> 4b. Use try-with-resource within
>>> PropertyFileConfigSource#loadProperties
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> On Fri, 8 Jun 2018 at 14:02, Romain Manni-Bucau <[hidden email]> wrote:
>>> +1, also migrated a few apps from deltaspike and once the API missing features worked around it seems working well.
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>>>
>>>
>>> Le ven. 8 juin 2018 à 13:55, Mark Struberg <[hidden email]> a écrit :
>>> Hi folks!
>>>
>>> I fixed a few missing parts and did run the release steps for geronimo-config-1.2
>>> This implements the microprofile-config-1.3 spec.
>>>
>>> The staging repository is here:
>>> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/
>>>
>>> The source zip is under
>>> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
>>> sha1 is 7de2e31a5022379f093d1f186aab97d731fe24a5
>>>
>>> Please VOTE:
>>>
>>> [+1] yea, let's ship it!
>>> [+0] meh, don't care
>>> [-1] stop because ${showstopper}
>>>
>>> The VOTE is open for 72h
>>>
>>> txs and LieGrue,
>>> strub
>>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] [CANCELLED] Release Apache Geronimo-config 1.2 (mp-config-1.3 spec)

Mark Struberg
In reply to this post by Mark Struberg
cancelled due to classloader issue.

Will roll a fresh release soon.

LieGrue,
strub

> Am 08.06.2018 um 13:54 schrieb Mark Struberg <[hidden email]>:
>
> Hi folks!
>
> I fixed a few missing parts and did run the release steps for geronimo-config-1.2
> This implements the microprofile-config-1.3 spec.
>
> The staging repository is here:
> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/
>
> The source zip is under
> https://repository.apache.org/content/repositories/orgapachegeronimo-1057/org/apache/geronimo/config/geronimo-config/1.2/
> sha1 is 7de2e31a5022379f093d1f186aab97d731fe24a5
>
> Please VOTE:
>
> [+1] yea, let's ship it!
> [+0] meh, don't care
> [-1] stop because ${showstopper}
>
> The VOTE is open for 72h
>
> txs and LieGrue,
> strub
>