[config] trunk version is 1.3?

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[config] trunk version is 1.3?

Romain Manni-Bucau
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Romain Manni-Bucau
Ok,


can it be reverted please (just the version)?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

jlmonteiro
I think so. Mistake maybe

Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
Ok,


can it be reverted please (just the version)?


Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Romain Manni-Bucau
Oki, do you revert it (or i can do it tomorrow)?

Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I think so. Mistake maybe

Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
Ok,


can it be reverted please (just the version)?


Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

jlmonteiro
I can do tomorrow if you want


Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
Oki, do you revert it (or i can do it tomorrow)?

Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I think so. Mistake maybe

Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
Ok,


can it be reverted please (just the version)?


Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

jlmonteiro
If I forget, just ping me in the morning

Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I can do tomorrow if you want


Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
Oki, do you revert it (or i can do it tomorrow)?

Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I think so. Mistake maybe

Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
Ok,


can it be reverted please (just the version)?


Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Romain Manni-Bucau
Oki, thanks JL.

Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
If I forget, just ping me in the morning

Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I can do tomorrow if you want


Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
Oki, do you revert it (or i can do it tomorrow)?

Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
I think so. Mistake maybe

Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
Ok,


can it be reverted please (just the version)?


Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book


Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
Hi guys,

why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book
Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Mark Struberg
The lookup logic is also wrong.

I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement.
The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might become rather expensive.

This is still under discussion.

LieGrue,
strub


> Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[hidden email]>:
>
> Oki, thanks JL.
>
> Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> If I forget, just ping me in the morning
>
> Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> I can do tomorrow if you want
>
>
> Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
> Oki, do you revert it (or i can do it tomorrow)?
>
> Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> I think so. Mistake maybe
>
> Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
> Ok,
>
> seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
>
> can it be reverted please (just the version)?
>
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
> Hi guys,
>
> why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book

Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Romain Manni-Bucau
Well the version is breaking people relying on snapshots for now

The lookup is not "wrong" but maybe not "final" ;)
The expensive part is quite not true since you will not evaluate it a lot in general and even in such a case it is a light algorithm normally. The current impl is wrongly using "replace("${" + varName + "}", variableValue);" which is way more expensive than using substrings (prefix+value+suffix) but overall it is acceptable for the config scope.
Not having the ability to have the ~same evaluation of values+defaults than StrSubstitutor of [lang3] is quite a pain cause users and really used to rely on that and it is mandatory for some path to use ${app.home}.


Le jeu. 7 juin 2018 à 10:56, Mark Struberg <[hidden email]> a écrit :
The lookup logic is also wrong.

I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement.
The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might become rather expensive.

This is still under discussion.

LieGrue,
strub


> Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[hidden email]>:
>
> Oki, thanks JL.
>
> Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> If I forget, just ping me in the morning
>
> Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> I can do tomorrow if you want
>
>
> Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
> Oki, do you revert it (or i can do it tomorrow)?
>
> Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> I think so. Mistake maybe
>
> Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
> Ok,
>
> seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
>
> can it be reverted please (just the version)?
>
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>
>
> Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
> Hi guys,
>
> why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book

Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Mark Struberg
No the lookup is wrong as it uss an illegal shortcut.
You would have to 'normalize' both ends to do it that way.

LiGrue,
strub


> Am 07.06.2018 um 11:06 schrieb Romain Manni-Bucau <[hidden email]>:
>
> Well the version is breaking people relying on snapshots for now
>
> The lookup is not "wrong" but maybe not "final" ;)
> The expensive part is quite not true since you will not evaluate it a lot in general and even in such a case it is a light algorithm normally. The current impl is wrongly using "replace("${" + varName + "}", variableValue);" which is way more expensive than using substrings (prefix+value+suffix) but overall it is acceptable for the config scope.
> Not having the ability to have the ~same evaluation of values+defaults than StrSubstitutor of [lang3] is quite a pain cause users and really used to rely on that and it is mandatory for some path to use ${app.home}.
>
>
> Le jeu. 7 juin 2018 à 10:56, Mark Struberg <[hidden email]> a écrit :
> The lookup logic is also wrong.
>
> I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement.
> The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might become rather expensive.
>
> This is still under discussion.
>
> LieGrue,
> strub
>
>
> > Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[hidden email]>:
> >
> > Oki, thanks JL.
> >
> > Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > If I forget, just ping me in the morning
> >
> > Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > I can do tomorrow if you want
> >
> >
> > Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
> > Oki, do you revert it (or i can do it tomorrow)?
> >
> > Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > I think so. Mistake maybe
> >
> > Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
> > Ok,
> >
> > seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
> >
> > can it be reverted please (just the version)?
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> >
> >
> > Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
> > Hi guys,
> >
> > why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>

Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Romain Manni-Bucau
Not sure what it means Mark, do you have an example handy?

Le jeu. 7 juin 2018 11:55, Mark Struberg <[hidden email]> a écrit :
No the lookup is wrong as it uss an illegal shortcut.
You would have to 'normalize' both ends to do it that way.

LiGrue,
strub


> Am 07.06.2018 um 11:06 schrieb Romain Manni-Bucau <[hidden email]>:
>
> Well the version is breaking people relying on snapshots for now
>
> The lookup is not "wrong" but maybe not "final" ;)
> The expensive part is quite not true since you will not evaluate it a lot in general and even in such a case it is a light algorithm normally. The current impl is wrongly using "replace("${" + varName + "}", variableValue);" which is way more expensive than using substrings (prefix+value+suffix) but overall it is acceptable for the config scope.
> Not having the ability to have the ~same evaluation of values+defaults than StrSubstitutor of [lang3] is quite a pain cause users and really used to rely on that and it is mandatory for some path to use ${app.home}.
>
>
> Le jeu. 7 juin 2018 à 10:56, Mark Struberg <[hidden email]> a écrit :
> The lookup logic is also wrong.
>
> I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement.
> The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might become rather expensive.
>
> This is still under discussion.
>
> LieGrue,
> strub
>
>
> > Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[hidden email]>:
> >
> > Oki, thanks JL.
> >
> > Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > If I forget, just ping me in the morning
> >
> > Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > I can do tomorrow if you want
> >
> >
> > Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
> > Oki, do you revert it (or i can do it tomorrow)?
> >
> > Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > I think so. Mistake maybe
> >
> > Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
> > Ok,
> >
> > seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
> >
> > can it be reverted please (just the version)?
> >
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> >
> >
> > Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
> > Hi guys,
> >
> > why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
> >
> > Romain Manni-Bucau
> > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
>

Reply | Threaded
Open this post in threaded view
|

Re: [config] trunk version is 1.3?

Mark Struberg
I'll tinker a test and check whether my gut feeling is wrong or right.

LieGrue,
strub


> Am 07.06.2018 um 14:05 schrieb Romain Manni-Bucau <[hidden email]>:
>
> Not sure what it means Mark, do you have an example handy?
>
> Le jeu. 7 juin 2018 11:55, Mark Struberg <[hidden email]> a écrit :
> No the lookup is wrong as it uss an illegal shortcut.
> You would have to 'normalize' both ends to do it that way.
>
> LiGrue,
> strub
>
>
> > Am 07.06.2018 um 11:06 schrieb Romain Manni-Bucau <[hidden email]>:
> >
> > Well the version is breaking people relying on snapshots for now
> >
> > The lookup is not "wrong" but maybe not "final" ;)
> > The expensive part is quite not true since you will not evaluate it a lot in general and even in such a case it is a light algorithm normally. The current impl is wrongly using "replace("${" + varName + "}", variableValue);" which is way more expensive than using substrings (prefix+value+suffix) but overall it is acceptable for the config scope.
> > Not having the ability to have the ~same evaluation of values+defaults than StrSubstitutor of [lang3] is quite a pain cause users and really used to rely on that and it is mandatory for some path to use ${app.home}.
> >
> >
> > Le jeu. 7 juin 2018 à 10:56, Mark Struberg <[hidden email]> a écrit :
> > The lookup logic is also wrong.
> >
> > I know emily pushes for more replacements, but we discussed this through in ConfigJSR and so far most are opposed to such a wide framed replacement.
> > The code is wrong as you cannot do just 1 fallback but you would have to do multiple fallback lookups. Which might become rather expensive.
> >
> > This is still under discussion.
> >
> > LieGrue,
> > strub
> >
> >
> > > Am 07.06.2018 um 06:44 schrieb Romain Manni-Bucau <[hidden email]>:
> > >
> > > Oki, thanks JL.
> > >
> > > Le jeu. 7 juin 2018 00:12, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > > If I forget, just ping me in the morning
> > >
> > > Le jeu. 7 juin 2018 à 00:11, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > > I can do tomorrow if you want
> > >
> > >
> > > Le mer. 6 juin 2018 à 20:25, Romain Manni-Bucau <[hidden email]> a écrit :
> > > Oki, do you revert it (or i can do it tomorrow)?
> > >
> > > Le mer. 6 juin 2018 19:51, Jean-Louis MONTEIRO <[hidden email]> a écrit :
> > > I think so. Mistake maybe
> > >
> > > Le mer. 6 juin 2018 à 14:28, Romain Manni-Bucau <[hidden email]> a écrit :
> > > Ok,
> > >
> > > seems it comes from the PR apply of https://github.com/apache/geronimo-config/commit/c2be10837190eb8ab30da6f491979cc54e445243
> > >
> > > can it be reverted please (just the version)?
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> > >
> > >
> > > Le mer. 6 juin 2018 à 14:23, Romain Manni-Bucau <[hidden email]> a écrit :
> > > Hi guys,
> > >
> > > why config trunk version is 1.3-SNAPSHOT and not 1.2-SNAPSHOT?
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau |  Blog | Old Blog | Github | LinkedIn | Book
> >
>