Quantcast

[jira] [Created] (GERONIMO-6002) Can't configure defaultJspServlet parameters

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Created] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org
Can't configure defaultJspServlet parameters
--------------------------------------------

                 Key: GERONIMO-6002
                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: Tomcat
    Affects Versions: 3.0
            Reporter: Kevan Miller
            Assignee: Kevan Miller
             Fix For: 3.0


It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046952#comment-13046952 ]

Kevan Miller commented on GERONIMO-6002:
----------------------------------------

With these changes, can now override xml attributes in config.xml. For instance:

{code}
    <module name="org.apache.geronimo.configs/jasper-deployer/3.0-SNAPSHOT/car">
      <gbean name="JspModuleBuilderExtension">
        <attribute name="defaultJspServlet">
          <web-app xmlns="http://java.sun.com/xml/ns/javaee">
            <servlet>
              <servlet-name>jsp</servlet-name>
              <servlet-class>org.apache.jasper.servlet.JspServlet</servlet-class>
              <init-param>
                <param-name>development</param-name>
                <param-value>true</param-value>
              </init-param>
              <init-param>
                <param-name>trimSpaces</param-name>
                <param-value>true</param-value>
              </init-param>
              <init-param>
                <param-name>fork</param-name>
                <param-value>false</param-value>
              </init-param>
              <init-param>
                <param-name>logVerbosityLevel</param-name>
                <param-value>DEBUG</param-value>
              </init-param>
              <init-param>
                <param-name>xpoweredBy</param-name>
                <param-value>false</param-value>
              </init-param>
              <init-param>
                <param-name>engineOptionsClass</param-name>
                <param-value>org.apache.geronimo.jasper.JspServletOptions</param-value>
              </init-param>
              <load-on-startup>0</load-on-startup>
            </servlet>
            <servlet-mapping>
              <servlet-name>jsp</servlet-name>
              <url-pattern>*.jsp</url-pattern>
              <url-pattern>*.jspf</url-pattern>
              <url-pattern>*.jspx</url-pattern>
              <url-pattern>*.xsp</url-pattern>
            </servlet-mapping>
          </web-app>
        </attribute>
      </gbean>
    </module>
{code}

Could add this to <config-xml-content> for jasper-deployer. But, should consider letting var/catalina/conf/web.xml control these settings. Something for later...

> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052820#comment-13052820 ]

Jarek Gawor commented on GERONIMO-6002:
---------------------------------------

These changes make it easier to configure various Jasper settings for the default jsp servlet that handles files with .jsp and other extensions. However, this does not affect Jasper settings when a jsp-servlet is configured (via <servlet><servlet-name>..</servlet-name><jsp-file>...</jsp-file></servlet>). I discovered that I had to replicate almost the same Jasper settings in the tomcat7-deployer configuration (in TomcatWebBuilder gbean - jspServlet attribute).
There should only really be one place where these Jasper settings should be set and work the same in both cases. Btw, the same Jasper configuration is also replicated in jetty8-deployer.


> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor updated GERONIMO-6002:
----------------------------------

    Attachment: jsp.development.mode

Attached is an example of modifications I had to do to config.xml to enable debug mode and configure trimSpaces option to work for JSPs (for both cases).
 

> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>         Attachments: jsp.development.mode
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Commented] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213437#comment-13213437 ]

xiezhi commented on GERONIMO-6002:
----------------------------------

Have verified it in geronimo 3.0-beta-1. It actually works for JSP with configuring enable debug module and trimSpaces Option.
               

> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>         Attachments: jsp.development.mode
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Resolved] (GERONIMO-6002) Can't configure defaultJspServlet parameters

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/GERONIMO-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

xiezhi resolved GERONIMO-6002.
------------------------------

    Resolution: Fixed

We have tested this configuration in geronimo 3.0-beta-1. It works.
               

> Can't configure defaultJspServlet parameters
> --------------------------------------------
>
>                 Key: GERONIMO-6002
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6002
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues)
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: Kevan Miller
>            Assignee: Kevan Miller
>             Fix For: 3.0
>
>         Attachments: jsp.development.mode
>
>
> It's not currently possible to configure the defaultJspServlet properties. This means that you can't configure 'development' mode or trimSpaces.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Loading...